Blinking of window tab (in panel) stops after a while

Please post suggestions for improvement of Cinnamon on:
https://github.com/linuxmint/Cinnamon
Forum rules
Before you post read how to get help. Topics in this forum are automatically closed 6 months after creation.
Locked
JakubRimal
Level 1
Level 1
Posts: 16
Joined: Thu Jan 30, 2014 4:42 pm

Blinking of window tab (in panel) stops after a while

Post by JakubRimal »

Hi,
after the upgrade to Linux Mint 17.2 Cinnamon 64-bit (Cinnamon 2.6.13) blinking of window tabs in panel does not work correctly.

Before the upgrade:
When some window wants to alert me (typically when someone writes me to the Pidgin), window tab in panel starts blink and it blinks until I focus to this window.

After the upgrade:
When some window wants to alert me (typically when someone writes me to the Pidgin), window tab in panel blinks only few times.

Do you know how to fix it or how to set it up to get the previous behaviour back?
Last edited by LockBot on Wed Dec 28, 2022 7:16 am, edited 1 time in total.
Reason: Topic automatically closed 6 months after creation. New replies are no longer allowed.
ulkhem

Re: Blinking of window tab (in panel) stops after a while

Post by ulkhem »

Yes, I miss the older behavior too, specially given that the Thunderbird notifications are broken currently.
dirtyernie

Re: Blinking of window tab (in panel) stops after a while

Post by dirtyernie »

I thought it was just me? :lol:
gigs94

Re: Blinking of window tab (in panel) stops after a while

Post by gigs94 »

I have the same issue and it's driving me nuts!!!! There has got to be a setting somewhere for this.
gigs94

Re: Blinking of window tab (in panel) stops after a while

Post by gigs94 »

I fixed it... You can edit this file: /usr/share/cinnamon/applets/window-list@cinnamon.org/applet.js and find this line:

Code: Select all

    _flashButton: function(counter) {
        if (!this._needsAttention)
            return;

        /* Put this next line here instead of after the if (counter == 4) block */
        this.actor.add_style_class_name("window-list-item-demands-attention");

        if (counter == 4)
            return;

        Mainloop.timeout_add(FLASH_INTERVAL, Lang.bind(this, function () {
            this.actor.remove_style_class_name("window-list-item-demands-attention");
        }));
        Mainloop.timeout_add(FLASH_INTERVAL * 2, Lang.bind(this, function () {
            this._flashButton(++counter);
        }));
    }
And then restart Cinnamon:

alt-f2 and then type r and hit enter
JakubRimal
Level 1
Level 1
Posts: 16
Joined: Thu Jan 30, 2014 4:42 pm

Re: Blinking of window tab (in panel) stops after a while

Post by JakubRimal »

gigs94 wrote:I fixed it... You can edit this file: /usr/share/cinnamon/applets/window-list@cinnamon.org/applet.js and find this line:

Code: Select all

    _flashButton: function(counter) {
        if (!this._needsAttention)
            return;

        /* Put this next line here instead of after the if (counter == 4) block */
        this.actor.add_style_class_name("window-list-item-demands-attention");

        if (counter == 4)
            return;

        Mainloop.timeout_add(FLASH_INTERVAL, Lang.bind(this, function () {
            this.actor.remove_style_class_name("window-list-item-demands-attention");
        }));
        Mainloop.timeout_add(FLASH_INTERVAL * 2, Lang.bind(this, function () {
            this._flashButton(++counter);
        }));
    }
And then restart Cinnamon:

alt-f2 and then type r and hit enter
Hi gigs94,
thank you very much! But for me it works weird when I just put that one line before the condition so I recommend to completely comment out (or delete) these two lines:

Code: Select all

        if (counter == 4)
            return;
Now it works as I think it should works. :)
gigs94

Re: Blinking of window tab (in panel) stops after a while

Post by gigs94 »

Well, I don't like it to "blink" and the previous behavior that I had was that it blinked several times and then stopped but kept the window tab illuminated. That's what the code does that I posted. Yours will just blink forever, but now people that want to can change it either way :D
JakubRimal
Level 1
Level 1
Posts: 16
Joined: Thu Jan 30, 2014 4:42 pm

Re: Blinking of window tab (in panel) stops after a while

Post by JakubRimal »

Yes, you are right. Now everyone can choose. ;)
Locked

Return to “Cinnamon”